Support for PHP 8.5 pipe operator by haidubogdan · Pull Request #9113 · apache/netbeans

haidubogdan · 2025-12-30T23:35:37Z

Part of issue #9034

include Php 8.5 version option

Pipe Operator

The IDE doesn't support this operator today.

So it requires updates on the lexer and parser level.
For the pipe operator I've used a similar approach to the infix expression and based on this rfc : https://wiki.php.net/rfc/function-composition I've created a new AstNode CompositionExpression (Maybe it should be FunctionCompostionExpression ?).
Trying to identify what is a variable or what is not a callable seemed to be very hard as you can assign a callable to a variable. Also, as it's a chain type expression there are no clear syntax delimiters to be included, so it can't be implemented as a stand alone AST rule.
For the error syntax I've used a hint verification approach of identifying what type of expression is the right handle of a Composition Expression. The basic types of numeric tokens or boolean values can be marked directly as errors.
In some future implementation we can add checks on callable types, as they require to take only one parameter (first-class-callables) .
https://wiki.php.net/rfc/pipe-operator-v3#callable_styles

syntax support for pipe operator
hint for basic non-callable pipe operator right handle : integer, float, bool, infix expression
formatting adaptation
unit tests for lexer, parser, hint verification

Todo | work in progress (while review is in progress :) )

unit test for formatting

^Add meaningful description above

Click to collapse/expand PR instructions

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

are all your own work, and you have the right to contribute them.
are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.

If you're a first time contributor, see the Contributing guidelines for more information.

If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.

PR approval and merge checklist:

Was this PR correctly labeled, did the right tests run? When did they run?
Is this PR squashed?
Are author name / email address correct? Are co-authors correctly listed? Do the commit messages need updates?
Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?

If this PR targets the delivery branch: don't merge. (full wiki article)

Issue apache#9034 - include Php 8.5 version option - syntax support for pipe opperator - hint for basic non-callable pipe operator right handle : integer, float, bool, infix expression

haidubogdan · 2026-02-18T06:07:19Z

@mbien , @matthiasblaesing

I wonder if there is still time to include this in NB 29.
Technically it's the only thing which can create a issue of using Php 8.5 on Netbeans as it shows the pipe operator to be an error syntax.

mbien · 2026-02-18T08:01:46Z

I wonder if there is still time to include this in NB 29.

@haidubogdan NB 29 is pretty much done unfortunately. There are no more RCs planned unless someone finds something release critical and we have to do another one. RC3 would become the release after vote.

tmysik

Overall, the PR looks good to me, thanks a lot for it! 👍

If we can, please let's wait a bit for @junichi11 as he is the main guy working on the PHP support in NetBeans, thank you.

tmysik · 2026-03-01T11:56:48Z

php/php.api.phpmodule/src/org/netbeans/modules/php/api/PhpVersion.java

    "PhpVersion.PHP_82=PHP 8.2",
    "PhpVersion.PHP_83=PHP 8.3",
    "PhpVersion.PHP_84=PHP 8.4",
+    "PhpVersion.PHP_85=PHP 8.5",


An API class is changed -> we need to increase the version of this API module.

(And this new version muist be used by other modules.)

tmysik · 2026-03-01T11:57:23Z

php/php.api.phpmodule/src/org/netbeans/modules/php/api/PhpVersion.java

     */
    PHP_84(Bundle.PhpVersion_PHP_84()),
+    /**
+     * PHP 8.4.


Suggested change

* PHP 8.4.

* PHP 8.5.

tmysik · 2026-03-01T11:59:17Z

php/php.editor/src/org/netbeans/modules/php/editor/indent/IndentationCounter.java

                                newIndent = Utilities.getRowIndent(doc, startExpression) + continuationSize;
                                break;
                            }
+                        } else if (ts.token().id() == PHPTokenId.PHP_OPERATOR && TokenUtilities.textEquals("|>", ts.token().text())) { // NOI18N


Just curious - don't we use constants for these PHP operators?

tmysik · 2026-03-01T12:00:08Z

php/php.editor/src/org/netbeans/modules/php/editor/parser/astnodes/visitors/DefaultVisitor.java

        scan(node.getIfFalse());
    }

+


Extra empty line added.

tmysik · 2026-03-01T12:02:30Z

php/php.editor/src/org/netbeans/modules/php/editor/parser/astnodes/CompositionExpression.java

+        super(start, end);
+
+        if (right == null || left == null) {
+            throw new IllegalArgumentException();


Please, add an exact error indicating what is wrong.

tmysik · 2026-03-01T12:05:46Z

php/php.editor/src/org/netbeans/modules/php/editor/parser/PHP5ErrorHandlerImpl.java

                case ASTPHP5Symbols.T_YIELD : text = "yield"; break; //NOI18N
                case ASTPHP5Symbols.T_YIELD_FROM : text = "yield from"; break; //NOI18N
                case ASTPHP5Symbols.T_READONLY : text = "readonly"; break; //NOI18N PHP 8.1
+                //skiping T_PIPE = "|>" PHP 8.5 as it doesn't bring much to the expected tokens error message


I don't understand exactly why we are skipping the pipe here. Can you explain/provide an example?

This change affects all the parser error messages + it's on a global version level, so the pipe operator will be suggested for Php 8.4 parser errors.
A lot of unit tests which shouldn't be impacted by the add of pipe operator will need to be recreated because it will mention pipe operator as a token suggestion.

tmysik · 2026-03-01T12:07:22Z

php/php.editor/src/org/netbeans/modules/php/editor/verification/PHP84UnhandledError.java

        @Override
        public String getDisplayName() {
-            return Bundle.PHP83VersionError_displayName();
+            return Bundle.PHP84VersionError_displayName();


Thanks for catching this.

tmysik · 2026-03-01T12:08:02Z

php/php.editor/src/org/netbeans/modules/php/editor/verification/PHP85UnhandledError.java

+        @NbBundle.Messages("PHP85VersionError.description=Detected language features not compatible with PHP version indicated in project settings")
+        @Override
+        public String getDescription() {
+            return Bundle.PHP83VersionError_description();


Suggested change

return Bundle.PHP83VersionError_description();

return Bundle.PHP85VersionError_description();

tmysik · 2026-03-01T12:09:57Z

php/php.editor/tools/ASTPHP5Scanner.flex

    return createSymbol(ASTPHP5Symbols.T_SR_EQUAL);
 }

+


Extra empty line.

mbien added PHP [ci] enable extra PHP tests (php/php.editor) ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Dec 31, 2025

apache locked and limited conversation to collaborators Dec 31, 2025

apache unlocked this conversation Dec 31, 2025

haidubogdan force-pushed the t_php85 branch from e5b3b0c to a167880 Compare December 31, 2025 05:56

haidubogdan added 3 commits January 12, 2026 11:26

Support for PHP 8.5 part 1

f4dc655

Issue apache#9034 - include Php 8.5 version option - syntax support for pipe opperator - hint for basic non-callable pipe operator right handle : integer, float, bool, infix expression

update license header to apache2 for parser cutter generated files

8e44011

- include formatter unit tests for pipe operator

052f4c3

haidubogdan force-pushed the t_php85 branch from e56f48d to 43e3f9b Compare January 12, 2026 09:26

- cleanup, add more comment info for composition expression

fbaeb2e

haidubogdan force-pushed the t_php85 branch from 43e3f9b to fbaeb2e Compare January 12, 2026 09:31

haidubogdan requested review from tmysik and troizet February 27, 2026 05:58

tmysik reviewed Mar 1, 2026

View reviewed changes

	return Bundle.PHP83VersionError_description();
	return Bundle.PHP85VersionError_description();

Conversation

haidubogdan commented Dec 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR approval and merge checklist:

Uh oh!

haidubogdan commented Feb 18, 2026

Uh oh!

mbien commented Feb 18, 2026

Uh oh!

tmysik left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

haidubogdan commented Dec 30, 2025 •

edited

Loading

tmysik left a comment •

edited

Loading